New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add windows and osx to travis #559
Conversation
note - we might want to wait on merging this - it looks like windows builds fail without any useful logs - windows on travis is in beta still |
Try to set |
Windows support in pino tests is broken altogether - I fixed it along the road in #626 |
Windows builds seem to just die quietly... |
yeah... annoying isn't it. Tried changing sudo: true - still failing |
Well, they do claim that windows support is quite preliminary. Maybe just run on Mac & Linux for now? |
well, the thing is I have windows successfully working on other projects – e.g. https://travis-ci.org/esxjs/esx so we need to check if pino tests run on windows at all (last we checked they did) and work from there |
@davidmarkclements Right, so here's the thing with tests on Windows - they are failing since we are skipping pretty.test.js tests on Windows due to colour code discrepancy, and this result in code coverage being below the threshold and thus task fails. Should the platform-specific assertion be implemented for those tests? |
This is covered by the move to GitHub Actions (which is complete in #747). |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.