Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows and osx to travis #559

Closed
wants to merge 4 commits into from
Closed

Conversation

davidmarkclements
Copy link
Member

No description provided.

@davidmarkclements
Copy link
Member Author

note - we might want to wait on merging this - it looks like windows builds fail without any useful logs - windows on travis is in beta still

@trygve-lie
Copy link
Contributor

Try to set sudo to true. I had simmilar issue and it turned out to be that Windows could not install dependencies without administrator rights. Yeah, logs are kinda useless on this.

@kibertoad
Copy link
Contributor

Windows support in pino tests is broken altogether - I fixed it along the road in #626

@kibertoad
Copy link
Contributor

Windows builds seem to just die quietly...

@davidmarkclements
Copy link
Member Author

Windows builds seem to just die quietly...

yeah... annoying isn't it. Tried changing sudo: true - still failing

@kibertoad
Copy link
Contributor

Well, they do claim that windows support is quite preliminary. Maybe just run on Mac & Linux for now?

@davidmarkclements
Copy link
Member Author

well, the thing is I have windows successfully working on other projects – e.g. https://travis-ci.org/esxjs/esx

so we need to check if pino tests run on windows at all (last we checked they did) and work from there

@kibertoad
Copy link
Contributor

@davidmarkclements Right, so here's the thing with tests on Windows - they are failing since we are skipping pretty.test.js tests on Windows due to colour code discrepancy, and this result in code coverage being below the threshold and thus task fails. Should the platform-specific assertion be implemented for those tests?

@jsumners
Copy link
Member

This is covered by the move to GitHub Actions (which is complete in #747).

@jsumners jsumners closed this Feb 22, 2020
@jsumners jsumners deleted the travis-windows-osx branch November 20, 2021 18:04
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants