CI : Github action improvement

[zekth]

As discussed in #743 (review) Adding the coverage job.

So it's on the same yml file because it's triggered by the same events:

on: [push, pull_request]

But it can be splitted. Also @jsumners in your example you do the matrix job but is it revelant to have it here? Because we want to test once the coverage and not the compatibility on each node version like in the build job. Do we keep it on only one node version like LTS ?

Note: Also increased the sleep in the pino.destination test because IO in the windows image seems to be slower and make the tests fail; with 300 it passes regularly.

Last run for ref : https://github.com/zekth/pino/commit/3aa8b0ff1a6110705638e3abeb786de44378da85/checks?check_suite_id=316635812

[jsumners]

The parallel configuration is necessary here because of the matrix of jobs. See https://github.com/coverallsapp/github-action/#complete-parallel-job-example

My suggestion to have a coverage.yml would result in, basically:

name: Coverage
runs-on: ubuntu-latest
steps:
  - uses: actions/checkout@v1
  - uses: actions/setup-node@v1
  - run: npm i
  - run: npm run cov-ci
  - uses: coverallsapp/github-action@master
     with:
        github-token: ${{ secrets.GITHUB_TOKEN }}

[zekth]

The parallel configuration is necessary here because of the matrix of jobs. See https://github.com/coverallsapp/github-action/#complete-parallel-job-example

My suggestion to have a coverage.yml would result in, basically:

name: Coverage
runs-on: ubuntu-latest
steps:
  - uses: actions/checkout@v1
  - uses: actions/setup-node@v1
  - run: npm i
  - run: npm run cov-ci
  - uses: coverallsapp/github-action@master
     with:
        github-token: ${{ secrets.GITHUB_TOKEN }}

Yeah totally agree, that's why i've asked in the PR. So which version of node you suggest? 12 (LTS) ?

[mcollina]

lgtm

[zekth]

CI seems still a bit flaky on Windows : https://github.com/pinojs/pino/runs/313765404

Increasing the sleep time? Seems like IO is randomly slow in this env.

[mcollina]

would you mind to send a PR? Il 26 nov 2019, 13:45 +0000, Vincent LE GOFF <notifications@github.com>, ha scritto:

…

CI seems still a bit flaky on Windows : https://github.com/pinojs/pino/runs/313765404 Increasing the sleep time? Seems like IO is randomly slow in this env. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.