Support Babel/Typescript "faux modules" as well as native ESM #936
Conversation
|
@anonrig please verify |
|
@fox1t maybe you can take a look as well |
|
@mcollina I started having seg fault. A pretty vague message, I'll investigate. sh: line 1: 815 Segmentation fault: 11 node build/index.js |
| module.exports.final = final | ||
| module.exports.levels = mappings() | ||
| module.exports.stdSerializers = serializers | ||
| module.exports.stdTimeFunctions = Object.assign({}, time) | ||
| module.exports.symbols = symbols | ||
| module.exports.version = version |
There was a problem hiding this comment.
I don't understand how this is any different than the prior code.
There was a problem hiding this comment.
Node.js now makes static analysis of your exports and if it finds module.exports it adds them as named export in the ESM context. The result in JS is the same as before, but writing it like this helps module interop!
|
OK, seg fault was due to another error by couchbase. It seems that this PR fixes the typescript bug. thanks @mcollina 👍 |
mcollina
force-pushed
the
add-default-function
branch
from
758721e
to
bc60603
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #935