Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to tap v15 #999

Merged
merged 1 commit into from Apr 1, 2021
Merged

Update to tap v15 #999

merged 1 commit into from Apr 1, 2021

Conversation

jsumners
Copy link
Member

@jsumners jsumners commented Apr 1, 2021

The alias deprecations was not fun. Refactoring all of the destructured is to equal was a nightmare (looking at you @davidmarkclements 馃槖 ). Doing a find/replace all on t.is was far easier.

@jsumners jsumners requested a review from mcollina April 1, 2021 13:53
mcollina
mcollina approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Not fun at all. There are like 50-something projects that I mantain that needs attention... it's going to be tough!

@jsumners jsumners merged commit df893a7 into master Apr 1, 2021
@jsumners jsumners deleted the bump-tap branch November 20, 2021 18:04
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsumners @mcollina