Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flush callback #182

Merged
merged 5 commits into from
Oct 5, 2023
Merged

add flush callback #182

merged 5 commits into from
Oct 5, 2023

Conversation

rluvaton
Copy link
Contributor

@rluvaton rluvaton commented Oct 4, 2023

allow knowing when flush is complete (this is to prepare for adding to pino the same cb)

Would appreciate adding theHACKTOBERFEST-ACCEPTED label once merged :)

mcollina
mcollina requested changes Oct 4, 2023
View reviewed changes
index.js Show resolved Hide resolved
index.js Show resolved Hide resolved
@rluvaton rluvaton requested a review from mcollina October 4, 2023 22:10
mcollina
mcollina approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rluvaton
Copy link
Contributor Author

rluvaton commented Oct 5, 2023 •
edited

Don't forget to add HACKTOBERFEST-ACCEPTED 😀

@mcollina mcollina merged commit d2a4786 into pinojs:master Oct 5, 2023
10 checks passed
@rluvaton rluvaton deleted the add-flush-callback branch October 5, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rluvaton @mcollina