Do not use FinalizationRegistry with NODE_V8_COVERAGE (#132)

Signed-off-by: Matteo Collina <hello@matteocollina.com>
pinojs · Oct 3, 2023 · 82943d9 · 82943d9
1 parent 2d20331
commit 82943d9
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -28,13 +28,16 @@ class FakeWeakRef {
   }
 }
 
-const FinalizationRegistry = global.FinalizationRegistry || class FakeFinalizationRegistry {
+class FakeFinalizationRegistry {
   register () {}
 
   unregister () {}
 }
 
-const WeakRef = global.WeakRef || FakeWeakRef
+// Currently using FinalizationRegistry with code coverage breaks the world
+// Ref: https://github.com/nodejs/node/issues/49344
+const FinalizationRegistry = process.env.NODE_V8_COVERAGE ? FakeFinalizationRegistry : global.FinalizationRegistry || FakeFinalizationRegistry
+const WeakRef = process.env.NODE_V8_COVERAGE ? FakeWeakRef : global.WeakRef || FakeWeakRef
 
 const registry = new FinalizationRegistry((worker) => {
   if (worker.exited) {