Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(indexes): enable test #101

Merged
merged 1 commit into from
Sep 5, 2022
Merged

test(indexes): enable test #101

merged 1 commit into from
Sep 5, 2022

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Aug 31, 2022

No description provided.

@mcollina
Copy link
Member

I have a feeling that file is not run at all. Could you switch to tap instead?

@Fdawgs
Copy link
Member Author

Fdawgs commented Sep 2, 2022

Is it worth just removing the file? Have ran the tests and you are right, it's not used.

@mcollina
Copy link
Member

mcollina commented Sep 2, 2022

It's actually a useful test, maybe make it run?

@Fdawgs Fdawgs changed the title build(deps-dev): add tape test(indexes): enable test Sep 2, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ec9e3a3 into main Sep 5, 2022
@mcollina mcollina deleted the Fdawgs-patch-2 branch September 5, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants