Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit warning when worker gracefully exit before finish #126

Merged
merged 5 commits into from
Aug 11, 2023
Merged

emit warning when worker gracefully exit before finish #126

merged 5 commits into from
Aug 11, 2023

Conversation

rluvaton
Copy link
Contributor

@rluvaton rluvaton commented Aug 9, 2023

mcollina
mcollina approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

I've added an exclude rukle for Windows Node.js v14, could you rebase?

@rluvaton rluvaton force-pushed the warn-if-exited-when-shouldnt branch from 7706910 to c16fc93 Compare August 10, 2023 11:59
@rluvaton
Copy link
Contributor Author

done

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5824010983

  • 4 of 9 (44.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 46.139%
Changes Missing Coverage Covered Lines Changed/Added Lines %
index.js 0 2 0.0%
lib/worker.js 4 7 57.14%
Totals Coverage Status
Change from base Build 5820733461: -0.08%
Covered Lines: 186
Relevant Lines: 365
💛 - Coveralls

@mcollina mcollina merged commit 1d18579 into pinojs:main Aug 11, 2023
17 checks passed
@rluvaton rluvaton deleted the warn-if-exited-when-shouldnt branch August 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rluvaton @mcollina @coveralls