Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): Fix import error when using pkg with node v20 #144

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

nagyszabi
Copy link
Contributor

Fixes: #143

@mcollina
Copy link
Member

A test would be highly welcomed, if you can give it a shot. You might want to use spawn to execute pkg.

@nagyszabi
Copy link
Contributor Author

I've created a test inside test/pkg which packages a tap test into an executable.

My reasoning behind this is that the test should run when packaged into an executable. And then I run each executable and test if there were no errors in stderr.

This is done for node 14, 16, 18 and 20, because I saw that these were used by github actions.

(I tested it on linux, but I'll fix the windows and macos tests as well)

@nagyszabi
Copy link
Contributor Author

Hello there!

I managed to fix the windows and macos tests, but I seem to be having some issues with the package managers.
For example the yarn test says that it requires at least node18 to run, so I think it's not related to my changes.

@mcollina mcollina merged commit 76b4b60 into pinojs:main Apr 22, 2024
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import error when using worker with pkg
2 participants