Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test php5.4 #368

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Test php5.4 #368

merged 2 commits into from
Sep 15, 2021

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Sep 15, 2021

Fix #367

@eeliu eeliu requested a review from EyelynSu September 15, 2021 03:21
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #368 (684e570) into master (47d8bf7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          20       20           
  Lines         918      918           
=======================================
  Hits          683      683           
  Misses        235      235           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d8bf7...684e570. Read the comment docs.

Copy link
Collaborator

@EyelynSu EyelynSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eeliu eeliu merged commit 75aa8f6 into pinpoint-apm:master Sep 15, 2021
@eeliu eeliu deleted the test-php5.4 branch December 22, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.4.6 php module make test fail
2 participants