Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] pinpoint_set_context_long leads crash in golang #437

Merged
merged 1 commit into from
May 7, 2022

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented May 7, 2022

  • remove noexcept

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #437 (03876bb) into master (5c4f03a) will decrease coverage by 0.47%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   75.47%   75.00%   -0.48%     
==========================================
  Files          20       20              
  Lines         954      960       +6     
==========================================
  Hits          720      720              
- Misses        234      240       +6     
Impacted Files Coverage Δ
common/src/common.cpp 69.87% <33.33%> (-2.14%) ⬇️
common/src/NodePool/PoolManager.cpp 82.92% <100.00%> (+2.43%) ⬆️
common/src/NodePool/PoolManager.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4f03a...03876bb. Read the comment docs.

@eeliu eeliu merged commit 823ead8 into pinpoint-apm:master May 7, 2022
@eeliu eeliu deleted the bug-set-long branch May 7, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant