Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] add pinpoint_add_traceV1 #444

Merged
merged 5 commits into from
May 20, 2022
Merged

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented May 20, 2022

eeliu added 4 commits May 20, 2022 10:55
* rename NodeID to enum
* remove c-style in TraceNode
> ci ✔

* unittest rename
* add register_span_handler
* testcase for mergeTraceNodeTree
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #444 (0a73863) into master (85b1f39) will increase coverage by 0.47%.
The diff coverage is 80.39%.

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   75.02%   75.50%   +0.47%     
==========================================
  Files          20       20              
  Lines         961     1041      +80     
==========================================
+ Hits          721      786      +65     
- Misses        240      255      +15     
Impacted Files Coverage Δ
common/src/common.cpp 66.66% <63.98%> (-3.34%) ⬇️
common/src/ConnectionPool/TransLayer.cpp 82.52% <83.33%> (+1.15%) ⬆️
common/src/Util/Helper.cpp 87.87% <87.87%> (-8.68%) ⬇️
common/src/NodePool/PoolManager.cpp 91.89% <94.44%> (+8.96%) ⬆️
common/src/NodePool/PoolManager.h 100.00% <100.00%> (ø)
common/src/NodePool/TraceNode.cpp 100.00% <100.00%> (ø)
common/src/NodePool/TraceNode.h 100.00% <100.00%> (ø)
common/src/Util/Helper.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b1f39...0a73863. Read the comment docs.

@eeliu eeliu requested a review from EyelynSu May 20, 2022 06:06
@eeliu eeliu enabled auto-merge (squash) May 20, 2022 06:07
@eeliu eeliu force-pushed the feat-trace-v1 branch 2 times, most recently from 92e8fe1 to 244052c Compare May 20, 2022 06:10
@eeliu eeliu merged commit 2cb2813 into pinpoint-apm:master May 20, 2022
Copy link
Collaborator

@EyelynSu EyelynSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eeliu eeliu deleted the feat-trace-v1 branch September 15, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants