Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] trace leak when load testing #448 #449

Merged
merged 1 commit into from
May 25, 2022
Merged

[fix] trace leak when load testing #448 #449

merged 1 commit into from
May 25, 2022

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented May 25, 2022

  • add show_status API
  • store root_start time, not ref root when use
  • leak_node testcase
  • catch out_of_range when no parent

@eeliu eeliu linked an issue May 25, 2022 that may be closed by this pull request
trace leak when load testing #448
Closed
@eeliu eeliu requested a review from EyelynSu May 25, 2022 08:52
@codecov
Copy link

codecov bot commented May 25, 2022 •
edited

Codecov Report

Merging #449 (5926657) into master (6cc60cd) will increase coverage by 0.20%.
The diff coverage is 57.69%.

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   75.50%   75.70%   +0.20%     
==========================================
  Files          20       20              
  Lines        1041     1062      +21     
==========================================
+ Hits          786      804      +18     
- Misses        255      258       +3
Impacted Files Coverage Δ
common/src/NodePool/TraceNode.h 100.00% <ø> (ø)
common/src/ConnectionPool/SpanConnectionPool.cpp 35.71% <33.33%> (ø)
common/src/common.cpp 67.01% <76.47%> (+0.34%) ⬆️
common/src/NodePool/PoolManager.h 100.00% <100.00%> (ø)
common/src/NodePool/TraceNode.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc60cd...5926657. Read the comment docs.

@eeliu
[fix] trace leak when load testing #448
5926657 
* add show_status API
* store root_start time, not ref root when use
* leak_node testcase
* catch out_of_range when no parent
EyelynSu
EyelynSu approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@EyelynSu EyelynSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eeliu eeliu merged commit da505d8 into master May 25, 2022
@eeliu eeliu deleted the 448-leaked-node branch May 25, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EyelynSu EyelynSu EyelynSu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trace leak when load testing
2 participants
@eeliu @EyelynSu