Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(collector-agent): protocol #533

Merged
merged 1 commit into from
Oct 13, 2023
Merged

refactor(collector-agent): protocol #533

merged 1 commit into from
Oct 13, 2023

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Oct 12, 2023 •
edited

  • ues pinpoint-grpc-idl@e68bc3963e7ba6f5c7e33f380f45111fddaaf938
  • map[string]interface{} to TSpan*
  • testcase
  • python version

[Task] clue/ctx_key limitation #531

close #531

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (9496d50) 76.64% compared to head (e3da322) 78.99%.
Report is 5 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #533      +/-   ##
==========================================
+ Coverage   76.64%   78.99%   +2.34%     
==========================================
  Files          18       18              
  Lines        1032     1071      +39     
==========================================
+ Hits          791      846      +55     
+ Misses        241      225      -16
Files Coverage Δ
common/src/NodePool/TraceNode.cpp 100.00% <100.00%> (ø)
common/src/Util/Helper.h 100.00% <100.00%> (ø)
common/src/NodePool/PoolManager.cpp 89.65% <96.00%> (+1.65%) ⬆️
common/src/Logging.c 85.71% <85.71%> (-0.96%) ⬇️
common/src/ConnectionPool/TransLayer.cpp 82.00% <85.18%> (-0.61%) ⬇️
common/src/Context/ContextType.h 58.33% <58.33%> (+2.08%) ⬆️
common/src/ConnectionPool/TransLayer.h 65.71% <66.34%> (-0.96%) ⬇️
common/src/common.cpp 75.95% <63.35%> (+8.28%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu eeliu force-pushed the feat-colon-limitation branch 2 times, most recently from c51bde1 to 7893787 Compare October 13, 2023 06:27
@eeliu
refactor(collector-agent): protocol
e3da322 
* ues pinpoint-grpc-idl@e68bc3963e7ba6f5c7e33f380f45111fddaaf938
* map[string]interface{} to TSpan*
* testcase php
* remove php5 testcase

[Task] clue/ctx_key limitation pinpoint-apm#531
@eeliu eeliu merged commit e152d2a into pinpoint-apm:dev Oct 13, 2023
14 of 15 checks passed
@eeliu eeliu deleted the feat-colon-limitation branch October 20, 2023 08:46
@eeliu eeliu added this to the v0.4.12 milestone Dec 4, 2023
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
refactor(collector-agent): protocol (#533)
c36b4d8 
* ues pinpoint-grpc-idl@e68bc3963e7ba6f5c7e33f380f45111fddaaf938
* map[string]interface{} to TSpan*
* testcase
* python version

[Task] clue/ctx_key limitation #531

close #531
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
refactor(collector-agent): protocol (#533)
7422eb1 
* ues pinpoint-grpc-idl@e68bc3963e7ba6f5c7e33f380f45111fddaaf938
* map[string]interface{} to TSpan*
* testcase
* python version

[Task] clue/ctx_key limitation #531

close #531
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
refactor(collector-agent): protocol (#533)
9b5d9a5 
* ues pinpoint-grpc-idl@e68bc3963e7ba6f5c7e33f380f45111fddaaf938
* map[string]interface{} to TSpan*
* testcase
* python version

[Task] clue/ctx_key limitation #531

close #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.

[Task] clue/ctx_key limitation
1 participant
@eeliu