Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): fastapi plugins for UT #540 #541

Merged
merged 1 commit into from
Oct 24, 2023
Merged

feat(python): fastapi plugins for UT #540 #541

merged 1 commit into from
Oct 24, 2023

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Oct 23, 2023

  • rename lib name for naming collision
  • testcase for ut

close #540

@eeliu
Copy link
Collaborator Author

eeliu commented Oct 23, 2023

test case https://github.com/pinpoint-apm/pinpoint-c-agent/pull/541/files#diff-357c1ac1d734f0dfdc2fa029c9e9df13d8b1973ca549931615e8ae0c5607c2d0

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (9496d50) 76.64% compared to head (cfc73eb) 78.89%.
Report is 10 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #541      +/-   ##
==========================================
+ Coverage   76.64%   78.89%   +2.25%     
==========================================
  Files          18       18              
  Lines        1032     1071      +39     
==========================================
+ Hits          791      845      +54     
+ Misses        241      226      -15
Files Coverage Δ
common/src/Cache/SharedObj.cpp 68.33% <ø> (ø)
common/src/NodePool/TraceNode.cpp 100.00% <100.00%> (ø)
common/src/Util/Helper.h 100.00% <100.00%> (ø)
common/src/Logging.cpp 85.71% <85.71%> (ø)
common/src/NodePool/PoolManager.cpp 87.93% <92.00%> (-0.07%) ⬇️
common/src/ConnectionPool/TransLayer.cpp 82.00% <85.18%> (-0.61%) ⬇️
common/src/Context/ContextType.h 58.33% <58.33%> (+2.08%) ⬆️
common/src/ConnectionPool/TransLayer.h 65.71% <66.34%> (-0.96%) ⬇️
common/src/common.cpp 75.95% <63.35%> (+8.28%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu eeliu force-pushed the feat-540-python branch 6 times, most recently from aee4d9e to b6b2c5c Compare October 23, 2023 10:00
@eeliu
feat(python): fastapi plugins for UT pinpoint-apm#540
cfc73eb 
- rename lib name for nameing collision
- testcase for ut

close pinpoint-apm#540
@eeliu eeliu mentioned this pull request Oct 24, 2023
Closed
5 tasks
@eeliu eeliu merged commit 06fdd37 into pinpoint-apm:dev Oct 24, 2023
14 of 15 checks passed
@eeliu eeliu added this to the v0.4.12 milestone Dec 4, 2023
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
feat(python): fastapi plugins for UT #540 (#541)
349cca7 
- rename lib name for naming collision
- testcase for ut

close #540
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
feat(python): fastapi plugins for UT #540 (#541)
eb3addc 
- rename lib name for naming collision
- testcase for ut

close #540
eeliu added a commit that referenced this pull request Mar 28, 2024
@eeliu
feat(python): fastapi plugins for UT #540 (#541)
8be150b 
- rename lib name for naming collision
- testcase for ut

close #540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.

fastapi plugins for UT
1 participant
@eeliu