Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pinpointpy): pinpointpy libs #551

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Nov 17, 2023

  • add httpbin
  • refactoring : logger ,pinpointpy/libs
    • mongo
    • db/mysql ...
    • request*
  • framework: Bottle,Django,pyramid,pyweb,pyweb2
  • testcase

- add httpbin
- return E_INVALID_NODE in root trace
- refactoring : logger ,pinpointpy/libs
   - mongo
   - db/mysql ...
   - request*
- framework: Bottle,Django,pyramid,pyweb,pyweb2
- testcase

close pinpoint-apm#549
@eeliu eeliu requested a review from EyelynSu November 17, 2023 02:26
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (9496d50) 76.64% compared to head (0434df0) 78.95%.
Report is 16 commits behind head on dev.

Files Patch % Lines
common/src/common.cpp 63.80% 59 Missing ⚠️
common/src/ConnectionPool/TransLayer.h 66.34% 35 Missing ⚠️
common/src/Context/ContextType.h 58.33% 5 Missing ⚠️
common/src/ConnectionPool/TransLayer.cpp 85.18% 4 Missing ⚠️
common/src/Logging.cpp 85.71% 2 Missing ⚠️
common/src/NodePool/PoolManager.cpp 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #551      +/-   ##
==========================================
+ Coverage   76.64%   78.95%   +2.30%     
==========================================
  Files          18       18              
  Lines        1032     1074      +42     
==========================================
+ Hits          791      848      +57     
+ Misses        241      226      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu eeliu force-pushed the feat-sync-async branch 5 times, most recently from f8ce6d8 to 4f31631 Compare November 17, 2023 08:45
@eeliu eeliu mentioned this pull request Nov 17, 2023
2 tasks
@eeliu eeliu merged commit dba2d81 into pinpoint-apm:dev Nov 17, 2023
16 of 17 checks passed
@eeliu eeliu deleted the feat-sync-async branch November 17, 2023 09:34
@eeliu eeliu added this to the v0.4.12 milestone Dec 4, 2023
eeliu added a commit that referenced this pull request Mar 28, 2024
- add httpbin
- refactoring : logger ,pinpointpy/libs
   - mongo
   - db/mysql ...
   - request*
- framework: Bottle,Django,pyramid,pyweb,pyweb2
- testcase
eeliu added a commit that referenced this pull request Mar 28, 2024
- add httpbin
- refactoring : logger ,pinpointpy/libs
   - mongo
   - db/mysql ...
   - request*
- framework: Bottle,Django,pyramid,pyweb,pyweb2
- testcase
eeliu added a commit that referenced this pull request Mar 28, 2024
- add httpbin
- refactoring : logger ,pinpointpy/libs
   - mongo
   - db/mysql ...
   - request*
- framework: Bottle,Django,pyramid,pyweb,pyweb2
- testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant