Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove one more "/" #562

Merged
merged 1 commit into from
Nov 23, 2023
Merged

remove one more "/" #562

merged 1 commit into from
Nov 23, 2023

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Nov 23, 2023

Describe your changes

Fix a bug in fastapi plugins

image

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (9496d50) 76.64% compared to head (e64077a) 78.95%.
Report is 30 commits behind head on dev.

Files Patch % Lines
common/src/common.cpp 63.80% 59 Missing ⚠️
common/src/ConnectionPool/TransLayer.h 66.34% 35 Missing ⚠️
common/src/Context/ContextType.h 58.33% 5 Missing ⚠️
common/src/ConnectionPool/TransLayer.cpp 85.18% 4 Missing ⚠️
common/src/Logging.cpp 85.71% 2 Missing ⚠️
common/src/NodePool/PoolManager.cpp 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #562      +/-   ##
==========================================
+ Coverage   76.64%   78.95%   +2.30%     
==========================================
  Files          18       18              
  Lines        1032     1074      +42     
==========================================
+ Hits          791      848      +57     
+ Misses        241      226      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu eeliu merged commit 9c9f81b into pinpoint-apm:dev Nov 23, 2023
16 of 17 checks passed
@eeliu eeliu deleted the fix-slash branch November 23, 2023 08:55
eeliu added a commit to eeliu/pinpoint-c-agent that referenced this pull request Nov 23, 2023
eeliu added a commit to eeliu/pinpoint-c-agent that referenced this pull request Nov 23, 2023
eeliu added a commit that referenced this pull request Nov 24, 2023
* update common version id 
* add test for #562
* fix useless fail
* fix backend crash
@eeliu eeliu added this to the v0.4.12 milestone Dec 4, 2023
eeliu added a commit that referenced this pull request Mar 28, 2024
eeliu added a commit that referenced this pull request Mar 28, 2024
* update common version id 
* add test for #562
* fix useless fail
* fix backend crash
eeliu added a commit that referenced this pull request Mar 28, 2024
eeliu added a commit that referenced this pull request Mar 28, 2024
* update common version id 
* add test for #562
* fix useless fail
* fix backend crash
eeliu added a commit that referenced this pull request Mar 28, 2024
eeliu added a commit that referenced this pull request Mar 28, 2024
* update common version id 
* add test for #562
* fix useless fail
* fix backend crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant