Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md #568

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Update Readme.md #568

merged 2 commits into from
Dec 7, 2023

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Dec 1, 2023

fix doc

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (9496d50) 76.64% compared to head (d195792) 81.34%.
Report is 37 commits behind head on dev.

❗ Current head d195792 differs from pull request most recent head c42e786. Consider uploading reports for the commit c42e786 to get more accurate results

Files Patch % Lines
common/src/common.cpp 73.00% 44 Missing ⚠️
common/src/ConnectionPool/TransLayer.h 66.34% 35 Missing ⚠️
common/src/Context/ContextType.h 58.33% 5 Missing ⚠️
common/src/ConnectionPool/TransLayer.cpp 85.18% 4 Missing ⚠️
common/src/Logging.cpp 85.71% 2 Missing ⚠️
common/src/NodePool/PoolManager.cpp 92.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #568      +/-   ##
==========================================
+ Coverage   76.64%   81.34%   +4.70%     
==========================================
  Files          18       18              
  Lines        1032     1067      +35     
==========================================
+ Hits          791      868      +77     
+ Misses        241      199      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu eeliu added this to the v0.4.14-patch milestone Dec 7, 2023
@eeliu eeliu merged commit 618a546 into dev Dec 7, 2023
17 checks passed
@eeliu eeliu deleted the eeliu-patch-1 branch December 7, 2023 06:34
eeliu added a commit that referenced this pull request Mar 28, 2024
eeliu added a commit that referenced this pull request Mar 28, 2024
eeliu added a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant