Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support IBM JDK #1756

Closed
emeroad opened this issue May 11, 2016 · 1 comment · Fixed by #1829
Closed

support IBM JDK #1756

emeroad opened this issue May 11, 2016 · 1 comment · Fixed by #1829
Assignees
@Xylus
Labels
enhancement
Milestone
1.6.0

Comments

@emeroad
Copy link
Member

emeroad commented May 11, 2016

related issue : Fixing profiler monitoring for different JVM
@emeroad emeroad added this to the 1.6.0 milestone May 11, 2016
Xylus added a commit to Xylus/pinpoint that referenced this issue Jun 3, 2016
@Xylus
pinpoint-apm#1756 Support CPU usage collection on IBM jvms
c43bc3d
@Xylus Xylus mentioned this issue Jun 3, 2016
Merged
@Xylus
Copy link
Contributor

Xylus commented Jun 3, 2016

Cpu load is collected from com.sun.management.OperatingSystemMXBean for Oracle JVMs, and from com.ibm.lang.management.OperatingSystemMXBean for IBM JVMs.

Since these classes are packaged in different JDKs, stub classes are created in optional packages under java-ibm and java-oracle directories under src/main/java to get the collector classes that reference the OperatingSystemMXBeans to compile.
These stub classes are there only for compilation, and are not packaged.

At runtime, the pinpoint agent detects it's current JVM and loads the appropriate collector classes which in turn will link the correct implementation of OperatingSystemMXBean.

jacarrichan added a commit to jacarrichan/pinpoint that referenced this issue May 6, 2017
@jacarrichan
pinpoint-apm#1756 Support CPU usage collection on IBM jvms (copy from p…
e2c0de4 
…inpoint-apm#1756)

# Conflicts:
#	profiler-optional/pom.xml
#	profiler-optional/profiler-optional-jdk7/src/main/java/com/navercorp/pinpoint/profiler/monitor/codahale/cpu/metric/EnhancedCpuLoadMetricSet.java
#	profiler-optional/profiler-optional-jdk7/src/main/java/com/navercorp/pinpoint/profiler/monitor/codahale/cpu/metric/oracle/DefaultCpuLoadMetricSet.java
#	profiler-optional/profiler-optional-parent/pom.xml
#	profiler-optional/src/main/java/com/navercorp/pinpoint/profiler/monitor/codahale/cpu/metric/EnhancedCpuLoadMetricSet.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xylus Xylus

Labels
enhancement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Adds CPU load collection on IBM J9 vms Xylus/pinpoint
2 participants
@emeroad @Xylus