Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending server meta data should be separated from the agent's lifecycle #215

Closed
Xylus opened this issue Mar 6, 2015 · 1 comment · Fixed by #224
Closed

Sending server meta data should be separated from the agent's lifecycle #215

Xylus opened this issue Mar 6, 2015 · 1 comment · Fixed by #224
Assignees
Milestone

Comments

@Xylus
Copy link
Contributor

Xylus commented Mar 6, 2015

The agent's lifecycle (and sending agent information) is currently controlled by plugins. Each plugin must specify if it will control the agent's lifecycle, and call Agent.start() manually if it does.

For example, a Tomcat 6 application is modified to invoke Agent.start() after org.apache.catalina.core.StandardService.start() method completes, and only then would the agent sends its information along with the server's meta data.

The agent's information should be sent regardless of the enclosing application's status, and this requires adding a way for the application to notify that it has finished gathering the server's meta data.

@Xylus
Copy link
Contributor Author

Xylus commented Mar 10, 2015

Making further modifications, It would be better for PinpointBootstrap to govern the agent's lifecycle (ie. start/stop methods).

Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 10, 2015
Xylus added a commit that referenced this issue Mar 10, 2015
[#215] Let bootstrap handle agent's lifecycle.
@emeroad emeroad added this to the 1.1.0 milestone Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants