Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server map does not show completely in mixed view page of new UI. #5565

Closed
messi-gao opened this issue May 7, 2019 · 12 comments
Closed

Server map does not show completely in mixed view page of new UI. #5565

messi-gao opened this issue May 7, 2019 · 12 comments
Assignees

Comments

@messi-gao
Copy link
Contributor

These two images are same data that show between old UI and new UI.As you can see,in old UI,the server map can show "Air Low Fare Search" and "Air Ancillaries Bundle Availability".But in new UI,it only shows the total count but does not show the detail info.
Could you tell me how to solve this problem? Thank you very much !
image
image

@denzelsN
Copy link
Contributor

denzelsN commented May 7, 2019

HI~ @messi-gao
You can see the ungrouped node by right-clicking on the server map and releasing the merge item.

@messi-gao
Copy link
Contributor Author

HI~ @messi-gao
You can see the ungrouped node by right-clicking on the server map and releasing the merge item.

@denzelsN Right-clicking on the server map only works in the home page,but does not work in other page.

image
home page works.
image
transactionList page does not work.
image
transactionView does not work.

@denzelsN
Copy link
Contributor

denzelsN commented May 8, 2019

@messi-gao
I forgot about transactionList and transactionView.
I'll fix it.
Thank you. :)

@messi-gao
Copy link
Contributor Author

messi-gao commented May 8, 2019

@messi-gao
I forgot about transactionList and transactionView.
I'll fix it.
Thank you. :)

@denzelsN If you fix it,please tell me. Thank you very much.

@denzelsN denzelsN self-assigned this May 8, 2019
denzelsN added a commit that referenced this issue May 8, 2019
- add context popup to server-map to transactionList and transactionView.
@denzelsN
Copy link
Contributor

denzelsN commented May 8, 2019

@messi-gao
Fixed it.

@messi-gao
Copy link
Contributor Author

messi-gao commented May 8, 2019

@messi-gao
Fixed it.

My local code from the tag:1.8.3,I am trying to modify the three files you metion.But when complile the code,there are some complile error.Could you modify the code based on code of the tag:1.8.3?
@denzelsN

@denzelsN
Copy link
Contributor

denzelsN commented May 8, 2019

@messi-gao
Change follow code in server-map-for-transaction-list-container.component.ts and server-map-for-transaction-view-container.component.ts:
But the context popup will open in a strange position.

// before
onContextClickBackground(coord: ICoordinate): void {
        this.dynamicPopupService.openPopup({
            data: this.mapData,
            coord,
            component: ServerMapContextPopupContainerComponent
        }, {
            resolver: this.componentFactoryResolver,
            injector: this.injector
        });
}
// after
onContextClickBackground(coord: ICoordinate): void {
        this.dynamicPopupService.openPopup({
            data: this.mapData,
            coord,
            component: ServerMapContextPopupContainerComponent
        });
}

@messi-gao
Copy link
Contributor Author

@denzelsN
Copy link
Contributor

denzelsN commented May 8, 2019

@messi-gao
Use updated code.

@messi-gao
Copy link
Contributor Author

You may not understand my meannings,I will show the error to you.
After changing the three files,There are compile error in server-map-for-transaction-list-container.component.ts and server-map-for-transaction-view-container.component.ts.The erro code is this.dynamicPopupService.openPopup function,it needs only one parameter,but after you modify it,it needs two parameters.
image
complie error

image
dynamic-popup.service.ts openPopup function in tag:1.8.3.

@denzelsN
Copy link
Contributor

denzelsN commented May 8, 2019

@messi-gao
So, I comment about it.

Remove second parameter ( before --> after )
#5565 (comment) <-- This code is only for you.

@messi-gao
Copy link
Contributor Author

@denzelsN You are right.I have saw it.As you say,The context popup will open in a strange position.I hope it could open in a normal position in Pinpoint next release.Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants