Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Kotlin Coroutines Plugin #8472

Closed
koo-taejin opened this issue Dec 8, 2021 · 2 comments
Closed

Support Kotlin Coroutines Plugin #8472

koo-taejin opened this issue Dec 8, 2021 · 2 comments
Assignees
@koo-taejin
Labels
enhancement module:plugin
Milestone
2.4.0

Comments

@koo-taejin
Copy link
Member

description

Support tracing for Kotlin Coroutines

Support Version

1.0.1 ~ 1.5.2(Latest)

Tracing description

Coroutines have two main types of behavior.

  1. Recreates the method inside the Coroutines's block
  2. Dispatches recreated method to worker
    L The object with tracing information is included.
  3. Executes recreated method
    L Create a new tracing root via step 2's object.

Notes :
If Coroutines use the parent's thread, it will be tracked even if you do not use the Kotlin plugin.
@koo-taejin koo-taejin added this to the 2.4.0 milestone Dec 8, 2021
@koo-taejin koo-taejin self-assigned this Dec 8, 2021
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Dec 8, 2021
@koo-taejin
[pinpoint-apm#8472] Support Kotlin Coroutines Plugin
107b5a2
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Dec 8, 2021
@koo-taejin
[pinpoint-apm#8472] Support Kotlin Coroutines Plugin
407994b
koo-taejin added a commit that referenced this issue Dec 8, 2021
@koo-taejin
[#8472] Support Kotlin Coroutines Plugin
f31832c
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Dec 9, 2021
@koo-taejin
[pinpoint-apm#8472] Update description for Coroutines plugin
ad50fda
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Dec 9, 2021
@koo-taejin
[pinpoint-apm#8472] Update description for Coroutines plugin
f8d0f4f
koo-taejin added a commit that referenced this issue Dec 9, 2021
@koo-taejin
[#8472] Update description for Coroutines plugin
5832a51
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Dec 9, 2021
@koo-taejin
[pinpoint-apm#8472] Support Kotlin Coroutines Plugin IT
0390532
koo-taejin added a commit that referenced this issue Dec 9, 2021
@koo-taejin
[#8472] Support Kotlin Coroutines Plugin IT
6894dad
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Dec 10, 2021
@koo-taejin @emeroad
[pinpoint-apm#8472] Support Kotlin Coroutines Plugin IT
70b85dd
emeroad added a commit to emeroad/pinpoint that referenced this issue Dec 10, 2021
@emeroad
[pinpoint-apm#8472] Fix pinpoint-kotlin-coroutines-plugin-it failure
16456c4
emeroad added a commit to emeroad/pinpoint that referenced this issue Dec 10, 2021
@emeroad
[pinpoint-apm#8472] Fix pinpoint-kotlin-coroutines-plugin-it failure
b39df9a
emeroad added a commit that referenced this issue Dec 10, 2021
@emeroad
[#8472] Fix pinpoint-kotlin-coroutines-plugin-it failure
a9b99ae
intr3p1d pushed a commit to intr3p1d/pinpoint that referenced this issue Dec 10, 2021
@koo-taejin @intr3p1d
[pinpoint-apm#8472] Support Kotlin Coroutines Plugin
0824ab4
intr3p1d pushed a commit to intr3p1d/pinpoint that referenced this issue Dec 10, 2021
@koo-taejin @intr3p1d
[pinpoint-apm#8472] Update description for Coroutines plugin
2f729a7
intr3p1d pushed a commit to intr3p1d/pinpoint that referenced this issue Dec 10, 2021
@koo-taejin @intr3p1d
[pinpoint-apm#8472] Support Kotlin Coroutines Plugin IT
685cf2c
intr3p1d pushed a commit to intr3p1d/pinpoint that referenced this issue Dec 10, 2021
@emeroad @intr3p1d
[pinpoint-apm#8472] Fix pinpoint-kotlin-coroutines-plugin-it failure
04110d0
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Dec 29, 2021
@koo-taejin
[pinpoint-apm#8472] Remove unnecessary log
35cbce7
koo-taejin added a commit that referenced this issue Dec 29, 2021
@koo-taejin
[#8472] Remove unnecessary log
b6dee28
@koo-taejin
Copy link
Member Author

At the time of development, I didn't understand fully about Kotlin Coroutine.
I have plan of revising this plugin. and I will send PR again.
I recommend that do not use this as much as possible during that period.

@koo-taejin koo-taejin reopened this Jan 21, 2022
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Jan 24, 2022
@koo-taejin
[pinpoint-apm#8472] Improves Coroutines plugin
9fd3421 
 1. Changes tracing target (Task.runSafely -> resumeWith)
    = RunSafely is a method that is executed only in case of a specific target, so it has been changed to a general method.
 2. Supports tracing threadName
 3. Supports tracing cancelling event
koo-taejin added a commit to koo-taejin/pinpoint that referenced this issue Jan 24, 2022
@koo-taejin
[pinpoint-apm#8472] Improves Coroutines plugin
cc77445 
 1. Changes tracing target (Task.runSafely -> resumeWith)
    = RunSafely is a method that is executed only in case of a specific target, so it has been changed to a general method.
 2. Supports tracing threadName
 3. Supports tracing cancelling event
@koo-taejin
Copy link
Member Author

coroutines

emeroad pushed a commit that referenced this issue Jan 24, 2022
@koo-taejin @emeroad
[#8472] Improves Coroutines plugin
d478253 
 1. Changes tracing target (Task.runSafely -> resumeWith)
    = RunSafely is a method that is executed only in case of a specific target, so it has been changed to a general method.
 2. Supports tracing threadName
 3. Supports tracing cancelling event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koo-taejin koo-taejin

Labels
enhancement module:plugin
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@koo-taejin