Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kafka-clients 3.1.x #8878

Closed
cj848 opened this issue May 22, 2022 · 2 comments
Closed

Support kafka-clients 3.1.x #8878

cj848 opened this issue May 22, 2022 · 2 comments
Assignees
Milestone

Comments

@cj848
Copy link

cj848 commented May 22, 2022

What version of pinpoint are you using?

I'm using 2.3.3, but it seems to be the same for a later version.

Describe the bug

polling interceptor code

changed kafka-clients code

As in the code above, the compatibility between the current pinpoint code and the latest version of the kafka-clients library is not compatible.

What did you do to trigger the bug?

It occurred in the process of upgrading Spring Boot from 2.6.7 -> 2.7.0 instead of directly upgrading kafka-clients, and spring boot users who do not care about the version of kafka-clients will experience an error when linking with pinpoint.

Expected behavior

The responseData method of Pinpoint's NetworkClientPollInterceptor must be called normally in kafka-clients versions 3.1.x or higher and 3.0.x versions.

Screenshots

image

Logs

java.lang.NoSuchMethodError: 'java.util.LinkedHashMap org.apache.kafka.common.requests.FetchResponse.responseData()'
	at com.navercorp.pinpoint.plugin.kafka.interceptor.NetworkClientPollInterceptor.after(NetworkClientPollInterceptor.java:86)
	at org.apache.kafka.clients.NetworkClient.poll(NetworkClient.java:577)
	at org.apache.kafka.clients.consumer.internals.ConsumerNetworkClient.poll(ConsumerNetworkClient.java:265)
	at org.apache.kafka.clients.consumer.internals.ConsumerNetworkClient.poll(ConsumerNetworkClient.java:236)
	at org.apache.kafka.clients.consumer.KafkaConsumer.pollForFetches(KafkaConsumer.java:1297)
	at org.apache.kafka.clients.consumer.KafkaConsumer.poll(KafkaConsumer.java:1238)
	at org.apache.kafka.clients.consumer.KafkaConsumer.poll(KafkaConsumer.java:1211)
	at org.springframework.kafka.listener.KafkaMessageListenerContainer$ListenerConsumer.pollConsumer(KafkaMessageListenerContainer.java:1522)
	at org.springframework.kafka.listener.KafkaMessageListenerContainer$ListenerConsumer.doPoll(KafkaMessageListenerContainer.java:1512)
	at org.springframework.kafka.listener.KafkaMessageListenerContainer$ListenerConsumer.pollAndInvoke(KafkaMessageListenerContainer.java:1340)
	at org.springframework.kafka.listener.KafkaMessageListenerContainer$ListenerConsumer.run(KafkaMessageListenerContainer.java:1252)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:833)
@cj848 cj848 changed the title Support kafka-client 3.1.x Support kafka-clients 3.1.x May 22, 2022
@emeroad emeroad added this to the 2.5.0 milestone May 23, 2022
@donguseo
Copy link

@cj848 Did you fix the problem?

@cj848
Copy link
Author

cj848 commented Jul 20, 2022

no i just wrote issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants