Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextCloser must not be rejected #9323

Closed
smilu97 opened this issue Oct 25, 2022 · 1 comment · Fixed by #9324 or #9339
Closed

ContextCloser must not be rejected #9323

smilu97 opened this issue Oct 25, 2022 · 1 comment · Fixed by #9324 or #9339
Assignees
Milestone

Comments

@smilu97
Copy link
Member

smilu97 commented Oct 25, 2022

onComplete listener in handleCommand must not be rejected for preventing memory leak.

For now, there is no adequate way to distinguish onNext, onComplete, onError in prior, so we decided to use CachedThreadPool as the serverExecutor just for the handleCommand service, and not to reject any events from that.

This action may temporarily applied, and be overrided by replacing every serverExecutor with CachedThreadPool because we have already checked most of heavy-IO jobs are being handed to another executors (worker executors), and so properly throttled.

@smilu97 smilu97 self-assigned this Oct 25, 2022
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 25, 2022
@smilu97 smilu97 changed the title HandleCommand events must not be rejected ContextCloser must not be rejected Oct 25, 2022
@smilu97
Copy link
Member Author

smilu97 commented Oct 25, 2022

Changed policy to ignore leaking from rejection of onComplete event, but augment queue size.

It only prevents ignoring ContextCloser which causes leak in the gRPC-managed resource pool.

smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 25, 2022
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 26, 2022
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 27, 2022
@emeroad emeroad added the bug label Oct 27, 2022
@emeroad emeroad added this to the 2.5.0 milestone Oct 27, 2022
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 27, 2022
emeroad pushed a commit to smilu97/pinpoint that referenced this issue Oct 27, 2022
emeroad added a commit to emeroad/pinpoint that referenced this issue Oct 28, 2022
@emeroad emeroad reopened this Oct 28, 2022
@emeroad emeroad linked a pull request Oct 28, 2022 that will close this issue
@emeroad emeroad closed this as completed Oct 28, 2022
BillionaireDY pushed a commit to BillionaireDY/pinpoint that referenced this issue Dec 29, 2022
BillionaireDY pushed a commit to BillionaireDY/pinpoint that referenced this issue Dec 29, 2022
BillionaireDY pushed a commit to BillionaireDY/pinpoint that referenced this issue Dec 29, 2022
BillionaireDY pushed a commit to BillionaireDY/pinpoint that referenced this issue Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants