-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current url statistics implementation for spring web can't properly collect failures #9357
Comments
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Nov 2, 2022
…ttribute when error happens
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Nov 2, 2022
…ttribute when error happens
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Nov 2, 2022
…ttribute when error happens
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Nov 3, 2022
…ttribute when error happens
ga-ram
added a commit
that referenced
this issue
Nov 3, 2022
BillionaireDY
pushed a commit
to BillionaireDY/pinpoint
that referenced
this issue
Dec 29, 2022
…ttribute when error happens
BillionaireDY
pushed a commit
to BillionaireDY/pinpoint
that referenced
this issue
Dec 29, 2022
…ttribute when error happens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current url statistics implementation for spring web uses request attribute
org.springframework.web.servlet.HandlerMapping.bestMatchingPattern
when collecting urls.When a request fails, this value changes to
/error
or any other url values set in spring propertyserver.error.path
.This may lead to an illusion that there is no failed requests in each url.
e.g.) when a request with initial bestMatchingPattern
/randomResponseTime/**
fails,/top50
response will be:Internally spring redirects failed requests to
/error
, so it may be correct but still misleading.I will add another interceptor to preserve initial bestMatchingPattern to another request attribute for Pinpoint to use when collecting url statistics for spring web.
The text was updated successfully, but these errors were encountered: