Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds checks for trace/stat tables on collector/web startup #2196

Merged
merged 1 commit into from
Oct 27, 2016

Conversation

Xylus
Copy link
Contributor

@Xylus Xylus commented Oct 27, 2016

This checks whether the required tables for trace and stat data are present in hbase when pinpoint collector and web starts up, instead of failing in runtime.
The required tables and the configuration settings are detailed in #2187.

resolves #2187

@Xylus Xylus added this to the 1.6.0 milestone Oct 27, 2016
@Xylus Xylus self-assigned this Oct 27, 2016
@codecov-io
Copy link

Current coverage is 40.51% (diff: 87.17%)

Merging #2196 into master will increase coverage by 0.21%

@@             master      #2196   diff @@
==========================================
  Files          1597       1597          
  Lines         55296      55377    +81   
  Methods       10883      10883          
  Messages          0          0          
  Branches       7611       7630    +19   
==========================================
+ Hits          22280      22434   +154   
+ Misses        33016      32943    -73   
  Partials          0          0          

Powered by Codecov. Last update 116bfce...bb34f96

@emeroad emeroad merged commit 03d7d5b into pinpoint-apm:master Oct 27, 2016
@Xylus Xylus deleted the feature/issue-2187 branch November 13, 2017 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow collector and web to fail fast when required tables for span/stat compatibility versions do not exist
3 participants