Fixes hostname retrieval triggering possible DNS lookups for Thrift plugin #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4427 +/- ##
==========================================
+ Coverage 40.78% 40.83% +0.04%
==========================================
Files 2487 2488 +1
Lines 75672 75687 +15
Branches 10243 10238 -5
==========================================
+ Hits 30863 30904 +41
+ Misses 41975 41952 -23
+ Partials 2834 2831 -3
Continue to review full report at Codecov.
|
Xylus
force-pushed
the
bugfix/issue-4389
branch
from
39d72bf
to
e859672
Compare
koo-taejin
reviewed
Aug 1, 2018
| private static HostStringAccessor createHostStringAccessor() { | ||
| try { | ||
| final Method m = InetSocketAddress.class.getDeclaredMethod("getHostString"); | ||
| m.setAccessible(true); |
There was a problem hiding this comment.
getHostString() in jdk6 is a package level accessor.
So all versions of jdk1.6 should be checked that method is included.
There was a problem hiding this comment.
@koo-taejin Thanks for the reminder.
getHostString() is present in 1.6.0_0 and in 1.6.0_45, so it should be there for other versions of 1.6 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue where the Thrift plugin would attempt a reverse DNS lookup when retrieving the host name if a TSocket was created using an address.
Utility methods are also added, which given an InetSocketAddress, would retrieve the host name or the address without triggering forward/reverse DNS lookup.
resolves #4389