Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8402] Add ServletFilter based ErrorHandler #8403

Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Nov 12, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #8403 (58333a7) into master (cfba4cb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8403      +/-   ##
============================================
- Coverage     39.86%   39.84%   -0.02%     
+ Complexity    11407    11406       -1     
============================================
  Files          3340     3340              
  Lines         89303    89304       +1     
  Branches       9913     9913              
============================================
- Hits          35597    35585      -12     
- Misses        50650    50659       +9     
- Partials       3056     3060       +4     
Impacted Files Coverage Δ
...va/com/navercorp/pinpoint/web/WebServerConfig.java 0.00% <0.00%> (ø)
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (-3.71%) ⬇️
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️
...point/rpc/client/DefaultPinpointClientHandler.java 70.77% <0.00%> (-1.41%) ⬇️
...m/navercorp/pinpoint/profiler/AgentInfoSender.java 82.56% <0.00%> (-0.92%) ⬇️
...java/com/navercorp/pinpoint/rpc/DefaultFuture.java 75.22% <0.00%> (+1.83%) ⬆️
.../navercorp/pinpoint/rpc/client/RequestManager.java 74.24% <0.00%> (+7.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfba4cb...58333a7. Read the comment docs.

@emeroad emeroad merged commit 15577df into pinpoint-apm:master Nov 12, 2021
@emeroad emeroad deleted the #8402_servletfilter_errorhandler branch November 15, 2021 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant