Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6821] Fix servermap instance list factory #8447

Merged

Conversation

jaehong-kim
Copy link
Contributor

#6821

When there is no transaction information, agentInfo information is used.

@jaehong-kim jaehong-kim added this to the 2.4.0 milestone Nov 30, 2021
@jaehong-kim jaehong-kim self-assigned this Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #8447 (163ad27) into master (3a919fa) will decrease coverage by 0.00%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8447      +/-   ##
============================================
- Coverage     39.76%   39.75%   -0.01%     
+ Complexity    11406    11396      -10     
============================================
  Files          3352     3352              
  Lines         89506    89512       +6     
  Branches       9922     9924       +2     
============================================
- Hits          35589    35583       -6     
  Misses        50867    50867              
- Partials       3050     3062      +12     
Impacted Files Coverage Δ
...er/server/StatisticsServerInstanceListFactory.java 0.00% <0.00%> (ø)
...navercorp/pinpoint/web/service/MapServiceImpl.java 0.00% <0.00%> (ø)
.../web/service/ResponseTimeHistogramServiceImpl.java 0.00% <0.00%> (ø)
...p/pinpoint/web/service/FilteredMapServiceImpl.java 61.97% <50.00%> (ø)
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 68.51% <0.00%> (-7.41%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...navercorp/pinpoint/rpc/common/SocketStateCode.java 81.25% <0.00%> (-3.13%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 75.60% <0.00%> (-2.44%) ⬇️
...point/rpc/client/DefaultPinpointClientHandler.java 71.83% <0.00%> (-1.41%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a919fa...163ad27. Read the comment docs.

@jaehong-kim jaehong-kim merged commit a189f01 into pinpoint-apm:master Dec 7, 2021
@jaehong-kim jaehong-kim deleted the fix-web-servermap-agent-hc branch September 21, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant