Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8544] Enhanced Pinpoint header validation #8546

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Dec 22, 2021

No description provided.

@emeroad emeroad linked an issue Dec 22, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #8546 (c12d5a4) into master (211b316) will increase coverage by 0.00%.
The diff coverage is 65.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8546   +/-   ##
=========================================
  Coverage     39.79%   39.80%           
- Complexity    11401    11402    +1     
=========================================
  Files          3348     3348           
  Lines         89328    89344   +16     
  Branches       9916     9923    +7     
=========================================
+ Hits          35550    35564   +14     
- Misses        50717    50722    +5     
+ Partials       3061     3058    -3     
Impacted Files Coverage Δ
...p/pinpoint/web/controller/AgentInfoController.java 0.00% <0.00%> (ø)
...pinpoint/web/controller/ApplicationController.java 0.00% <0.00%> (ø)
...p/pinpoint/common/profiler/util/TransactionId.java 29.62% <33.33%> (-2.38%) ⬇️
...point/common/profiler/util/TransactionIdUtils.java 70.31% <66.66%> (-0.38%) ⬇️
...ercorp/pinpoint/grpc/server/AgentHeaderReader.java 54.09% <66.66%> (+0.76%) ⬆️
...avercorp/pinpoint/common/util/IdValidateUtils.java 100.00% <100.00%> (+18.18%) ⬆️
...p/pinpoint/rpc/client/WriteFailFutureListener.java 56.25% <0.00%> (-25.00%) ⬇️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 46.66% <0.00%> (-6.67%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 79.83% <0.00%> (-2.06%) ⬇️
...point/rpc/client/DefaultPinpointClientHandler.java 70.77% <0.00%> (-1.41%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211b316...c12d5a4. Read the comment docs.

@emeroad emeroad merged commit e9d8282 into pinpoint-apm:master Dec 22, 2021
@emeroad emeroad deleted the #8544_header_validation branch December 22, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhanced Pinpoint header validation
2 participants