Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8642] Disable async trace to limit span event #8643

Merged
merged 2 commits into from
Feb 18, 2022
Merged

[#8642] Disable async trace to limit span event #8643

merged 2 commits into from
Feb 18, 2022

Conversation

Kangji
Copy link

@Kangji Kangji commented Feb 8, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #8643 (0906489) into master (7c85321) will increase coverage by 0.07%.
The diff coverage is 40.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8643      +/-   ##
============================================
+ Coverage     39.72%   39.79%   +0.07%     
- Complexity    11443    11475      +32     
============================================
  Files          3360     3362       +2     
  Lines         89698    89736      +38     
  Branches       9953     9955       +2     
============================================
+ Hits          35634    35714      +80     
+ Misses        51016    50964      -52     
- Partials       3048     3058      +10     
Impacted Files Coverage Δ
...orp/pinpoint/profiler/context/AsyncChildTrace.java 1.85% <0.00%> (+1.85%) ⬆️
...t/profiler/context/DefaultAsyncContextFactory.java 50.00% <0.00%> (ø)
...oint/profiler/context/DefaultBaseTraceFactory.java 49.46% <0.00%> (-1.09%) ⬇️
...oint/profiler/context/LoggingBaseTraceFactory.java 0.00% <0.00%> (ø)
...ontext/recorder/WrappedAsyncSpanEventRecorder.java 0.00% <0.00%> (ø)
...ler/context/recorder/WrappedSpanEventRecorder.java 25.35% <0.00%> (-0.37%) ⬇️
...point/profiler/context/DisableAsyncChildTrace.java 34.37% <34.37%> (ø)
...rp/pinpoint/profiler/context/DisableSpanEvent.java 50.00% <50.00%> (ø)
...pinpoint/profiler/context/DefaultAsyncContext.java 62.79% <70.00%> (+62.79%) ⬆️
...int/profiler/context/DefaultAsyncTraceContext.java 96.87% <100.00%> (+79.22%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85321...0906489. Read the comment docs.

@emeroad emeroad merged commit 1a501e8 into pinpoint-apm:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants