Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8663] Fix to generate DummySpanEvent on stack overflow of callstack #8664

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Feb 17, 2022

No description provided.

@emeroad emeroad linked an issue Feb 17, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #8664 (64152fe) into master (f5a472e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8664      +/-   ##
============================================
- Coverage     39.73%   39.71%   -0.02%     
- Complexity    11440    11442       +2     
============================================
  Files          3361     3360       -1     
  Lines         89709    89698      -11     
  Branches       9954     9953       -1     
============================================
- Hits          35642    35627      -15     
  Misses        51021    51021              
- Partials       3046     3050       +4     
Impacted Files Coverage Δ
...rp/pinpoint/profiler/context/DefaultCallStack.java 94.20% <100.00%> (+0.26%) ⬆️
...ercorp/pinpoint/profiler/context/DefaultTrace.java 61.40% <100.00%> (ø)
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...r/context/storage/AsyncQueueingUriStatStorage.java 69.11% <0.00%> (-16.18%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 75.92% <0.00%> (+3.70%) ⬆️
...pc/server/LoggingServerMessageListenerFactory.java 90.47% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a472e...64152fe. Read the comment docs.

@emeroad emeroad merged commit 7c85321 into pinpoint-apm:master Feb 17, 2022
@emeroad emeroad deleted the #8663_callstack branch February 17, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix to generate DummySpanEvent on stack overflow of callstack
1 participant