Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9229] Fix incorrect AKKA ServiceType #8921

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

koo-taejin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #8921 (abfbf43) into master (15c2a11) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #8921      +/-   ##
============================================
- Coverage     39.78%   39.78%   -0.01%     
+ Complexity    11771    11764       -7     
============================================
  Files          3367     3367              
  Lines         90905    90907       +2     
  Branches      10096    10096              
============================================
- Hits          36170    36169       -1     
- Misses        51642    51647       +5     
+ Partials       3093     3091       -2     
Impacted Files Coverage Δ
...m/navercorp/pinpoint/common/trace/ServiceType.java 100.00% <ø> (ø)
...int/plugin/akka/http/AkkaHttpMetadataProvider.java 0.00% <0.00%> (ø)
...p/pinpoint/plugin/akka/http/AkkaHttpConstants.java 75.00% <100.00%> (+8.33%) ⬆️
...inpoint/profiler/logging/Log4j2ContextFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...rofiler/logging/EmptyShutdownCallbackRegistry.java 0.00% <0.00%> (-100.00%) ⬇️
...rp/pinpoint/rpc/packet/ControlHandshakePacket.java 44.82% <0.00%> (-24.14%) ⬇️
...p/pinpoint/rpc/stream/StreamChannelRepository.java 57.89% <0.00%> (-21.06%) ⬇️
.../pinpoint/metric/common/pinot/PinotDataSource.java 45.45% <0.00%> (-4.55%) ⬇️
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 79.83% <0.00%> (+0.82%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@koo-taejin koo-taejin closed this Sep 27, 2022
@emeroad emeroad reopened this Sep 27, 2022
@emeroad emeroad changed the title [#noissue] Akka ServiceType looks weired [#9229] Fix incorrect AKKA ServiceType Sep 27, 2022
@emeroad emeroad linked an issue Sep 27, 2022 that may be closed by this pull request
@emeroad emeroad added this to the 2.5.0 milestone Sep 27, 2022
@emeroad emeroad merged commit 3c57c58 into pinpoint-apm:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix incorrect AKKA ServiceType
2 participants