Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8965] Add SharedTestLifeCycle to simplify plugin integration tests #8966

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 23, 2022

No description provided.

@emeroad emeroad linked an issue Jun 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #8966 (87a4359) into master (20001b3) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##             master    #8966      +/-   ##
============================================
- Coverage     39.83%   39.81%   -0.02%     
- Complexity    11834    11839       +5     
============================================
  Files          3351     3353       +2     
  Lines         91079    91139      +60     
  Branches      10084    10093       +9     
============================================
+ Hits          36279    36287       +8     
- Misses        51705    51747      +42     
- Partials       3095     3105      +10     
Impacted Files Coverage Δ
...t/test/plugin/shared/SharedPinpointPluginTest.java 0.00% <0.00%> (ø)
...test/plugin/shared/SharedTestLifeCycleWrapper.java 22.22% <22.22%> (ø)
...npoint/test/plugin/shared/ExecuteSharedThread.java 58.69% <23.52%> (-7.54%) ⬇️
...test/plugin/shared/SharedTestBeforeAllInvoker.java 88.88% <88.88%> (ø)
...p/pinpoint/rpc/stream/StreamChannelRepository.java 57.89% <0.00%> (-21.06%) ⬇️
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (-3.71%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20001b3...87a4359. Read the comment docs.

@emeroad emeroad merged commit 9fd59aa into pinpoint-apm:master Jun 23, 2022
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SharedTestLifeCycle to simplify plugin integration tests
1 participant