Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Fix port conflicts in integration test #8996

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 30, 2022

No description provided.

@emeroad emeroad changed the title [#noissue] Fix port conflicts in ActiveMq test [#noissue] Fix port conflicts in integration test Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #8996 (1f12801) into master (858900c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8996      +/-   ##
============================================
+ Coverage     39.72%   39.74%   +0.01%     
- Complexity    11789    11791       +2     
============================================
  Files          3345     3345              
  Lines         90839    90839              
  Branches      10057    10057              
============================================
+ Hits          36089    36104      +15     
+ Misses        51656    51646      -10     
+ Partials       3094     3089       -5     
Impacted Files Coverage Δ
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 21.59% <0.00%> (+1.13%) ⬆️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 88.74% <0.00%> (+4.63%) ⬆️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 75.92% <0.00%> (+7.40%) ⬆️
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 65.21% <0.00%> (+17.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858900c...1f12801. Read the comment docs.

@emeroad emeroad merged commit 42829b7 into pinpoint-apm:master Jun 30, 2022
@emeroad emeroad linked an issue Jun 30, 2022 that may be closed by this pull request
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
@emeroad emeroad added the test label Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SharedTestLifeCycle to simplify plugin integration tests
1 participant