Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9000] Use updateRuleExceptWebhookSend when webhook.enable=false #9007

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

ga-ram
Copy link
Contributor

@ga-ram ga-ram commented Jul 4, 2022

No description provided.

@ga-ram ga-ram linked an issue Jul 4, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #9007 (a238b15) into master (a8c8e20) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9007      +/-   ##
============================================
+ Coverage     39.74%   39.77%   +0.02%     
- Complexity    11794    11797       +3     
============================================
  Files          3347     3347              
  Lines         90823    90824       +1     
  Branches      10053    10053              
============================================
+ Hits          36101    36124      +23     
+ Misses        51626    51610      -16     
+ Partials       3096     3090       -6     
Impacted Files Coverage Δ
...vercorp/pinpoint/web/service/AlarmServiceImpl.java 0.00% <0.00%> (ø)
...pinpoint/rpc/ChannelWriteFailListenableFuture.java 42.85% <0.00%> (-28.58%) ⬇️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 46.66% <0.00%> (-6.67%) ⬇️
...java/com/navercorp/pinpoint/rpc/DefaultFuture.java 74.31% <0.00%> (-1.84%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 80.65% <0.00%> (-0.42%) ⬇️
...point/rpc/client/DefaultPinpointClientHandler.java 71.83% <0.00%> (+1.40%) ⬆️
...vercorp/pinpoint/web/vo/ApplicationAgentsList.java 72.36% <0.00%> (+2.63%) ⬆️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 88.74% <0.00%> (+4.63%) ⬆️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (+7.40%) ⬆️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 79.16% <0.00%> (+8.33%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8c8e20...a238b15. Read the comment docs.

@ga-ram ga-ram merged commit e4404f2 into pinpoint-apm:master Jul 4, 2022
@ga-ram ga-ram deleted the 9000 branch July 4, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column webhook_send is still used when webhook.enable property is false
1 participant