Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9078] Stable cleanup #9088

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Conversation

smilu97
Copy link
Member

@smilu97 smilu97 commented Aug 3, 2022

CleanupInactiveAgentsJob is enormous, and takes about 10h per execution.

  • It collects dead agents by traversing all agents, and frequently delete agents when 100 dead agents are found.
  • CleanupInactiveAgentsTasklet split chunks more granuly for preventing transaction-timeout-error

@smilu97 smilu97 force-pushed the #9078_stable_cleanup branch 2 times, most recently from 5337734 to 0a6b3df Compare August 3, 2022 05:57
@smilu97 smilu97 self-assigned this Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #9088 (cff2dce) into master (a903546) will decrease coverage by 0.02%.
The diff coverage is 53.33%.

❗ Current head cff2dce differs from pull request most recent head 0ba2f0a. Consider uploading reports for the commit 0ba2f0a to get more accurate results

@@             Coverage Diff              @@
##             master    #9088      +/-   ##
============================================
- Coverage     39.80%   39.78%   -0.03%     
+ Complexity    11739    11737       -2     
============================================
  Files          3351     3351              
  Lines         90334    90378      +44     
  Branches      10052    10054       +2     
============================================
- Hits          35960    35957       -3     
- Misses        51312    51358      +46     
- Partials       3062     3063       +1     
Impacted Files Coverage Δ
...npoint/batch/job/CleanupInactiveAgentsTasklet.java 0.00% <0.00%> (ø)
...vercorp/pinpoint/web/service/AdminServiceImpl.java 68.93% <74.07%> (-7.70%) ⬇️
...p/pinpoint/rpc/client/WriteFailFutureListener.java 56.25% <0.00%> (-25.00%) ⬇️
.../pinpoint/rpc/packet/stream/StreamClosePacket.java 57.14% <0.00%> (-25.00%) ⬇️
...p/pinpoint/rpc/stream/StreamChannelRepository.java 57.89% <0.00%> (-21.06%) ⬇️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 46.66% <0.00%> (-6.67%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 79.83% <0.00%> (-2.06%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smilu97 smilu97 merged commit 93ee21f into pinpoint-apm:master Aug 5, 2022
@smilu97 smilu97 deleted the #9078_stable_cleanup branch August 5, 2022 09:04
Copy link
Member

@minwoo-jung minwoo-jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants