Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Refactor ApplicationAgentsList #9228

Merged

Conversation

intr3p1d
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #9228 (dc91991) into master (47b0e1c) will decrease coverage by 0.22%.
The diff coverage is 60.26%.

@@             Coverage Diff              @@
##             master    #9228      +/-   ##
============================================
- Coverage     39.83%   39.61%   -0.23%     
- Complexity    11749    11791      +42     
============================================
  Files          3362     3394      +32     
  Lines         90671    91358     +687     
  Branches      10086    10127      +41     
============================================
+ Hits          36118    36188      +70     
- Misses        51473    52084     +611     
- Partials       3080     3086       +6     
Impacted Files Coverage Δ
.../authorization/controller/AgentInfoController.java 0.00% <0.00%> (ø)
...pinpoint/web/controller/ApplicationController.java 0.00% <ø> (ø)
...orp/pinpoint/web/service/AgentInfoServiceImpl.java 0.00% <0.00%> (ø)
...vercorp/pinpoint/web/view/tree/SimpleTreeView.java 0.00% <0.00%> (ø)
...npoint/web/view/tree/SimpleTreeViewSerializer.java 0.00% <0.00%> (ø)
...navercorp/pinpoint/web/view/tree/TreeNodeView.java 0.00% <0.00%> (ø)
...com/navercorp/pinpoint/web/vo/agent/AgentInfo.java 58.06% <ø> (-1.32%) ⬇️
...pinpoint/web/vo/tree/ApplicationAgentHostList.java 0.00% <ø> (ø)
.../navercorp/pinpoint/web/vo/tree/AgentsListMap.java 70.58% <70.58%> (ø)
...ava/com/navercorp/pinpoint/web/vo/tree/SortBy.java 88.23% <88.23%> (ø)
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@intr3p1d intr3p1d force-pushed the applicationagentslist_refactoring branch 7 times, most recently from 1e6335d to 822f259 Compare October 4, 2022 09:34
@intr3p1d intr3p1d self-assigned this Oct 5, 2022
@intr3p1d intr3p1d force-pushed the applicationagentslist_refactoring branch from 822f259 to 5f2adcf Compare October 5, 2022 09:26
@emeroad emeroad force-pushed the applicationagentslist_refactoring branch 2 times, most recently from ae57e43 to 5b80fa5 Compare October 7, 2022 06:56
@intr3p1d intr3p1d force-pushed the applicationagentslist_refactoring branch from ef9c3ad to ddaacfd Compare October 11, 2022 02:34
[#noissue] Add TreeView for ApplicationAgentsList
[#noissue] Refactor Comparator
@intr3p1d intr3p1d force-pushed the applicationagentslist_refactoring branch from ddaacfd to dc91991 Compare October 11, 2022 05:27
@intr3p1d intr3p1d merged commit 9f1bd6b into pinpoint-apm:master Oct 11, 2022
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants