Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9254] Collects and retrieves URL statistics using Pinot #9255

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

ga-ram
Copy link
Contributor

@ga-ram ga-ram commented Oct 11, 2022

Compared to the previous work, these are now changed:

  • profiler samples url statistics every 30 seconds (previously sampled every 60s)
  • profiler measures total time spent per url (previously measured the average time)
  • collector saves sampled url statistics to pinot (previously saved in hbase)
  • web response format has been changed to match system metrics data response format as of collect and view system metric data  #8004

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #9255 (9162b26) into master (bc17fa3) will decrease coverage by 0.19%.
The diff coverage is 24.86%.

@@             Coverage Diff              @@
##             master    #9255      +/-   ##
============================================
- Coverage     39.58%   39.38%   -0.20%     
+ Complexity    11831    11770      -61     
============================================
  Files          3409     3407       -2     
  Lines         91576    91260     -316     
  Branches      10161    10118      -43     
============================================
- Hits          36249    35943     -306     
+ Misses        52224    52214      -10     
  Partials       3103     3103              
Impacted Files Coverage Δ
...otstrap/plugin/request/ServletRequestListener.java 0.00% <0.00%> (ø)
.../bootstrap/plugin/uri/DisabledUriStatRecorder.java 0.00% <0.00%> (ø)
...npoint/bootstrap/plugin/uri/UriExtractorChain.java 0.00% <0.00%> (ø)
...nt/collector/service/EmptyAgentUriStatService.java 0.00% <0.00%> (ø)
...ver/bo/codec/stat/AgentStatCoderConfiguration.java 100.00% <ø> (ø)
...pinpoint/common/server/bo/stat/AgentUriStatBo.java 0.00% <0.00%> (-44.19%) ⬇️
.../pinpoint/common/server/bo/stat/EachUriStatBo.java 0.00% <0.00%> (-25.54%) ⬇️
...npoint/common/server/bo/stat/UriStatHistogram.java 0.00% <0.00%> (-38.89%) ⬇️
.../com/navercorp/pinpoint/common/util/MathUtils.java 25.00% <0.00%> (-2.28%) ⬇️
...nt/metric/collector/dao/pinot/PinotUriStatDao.java 0.00% <0.00%> (ø)
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Co-Authored-By: Woonduk Kang <emeroad@gmail.com>
@ga-ram ga-ram merged commit a6850ef into pinpoint-apm:master Oct 21, 2022
@ga-ram ga-ram deleted the 9254 branch October 21, 2022 08:14
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collects and retrieves URL statistics using Pinot
2 participants