Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9350] Replace Base64 with java.util.Base64 #9351

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Oct 31, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #9351 (4b8fc7c) into master (5d8cf38) will increase coverage by 0.08%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #9351      +/-   ##
============================================
+ Coverage     39.43%   39.52%   +0.08%     
- Complexity    11769    11782      +13     
============================================
  Files          3400     3399       -1     
  Lines         91122    91105      -17     
  Branches      10118    10113       -5     
============================================
+ Hits          35936    36007      +71     
+ Misses        52085    51975     -110     
- Partials       3101     3123      +22     
Impacted Files Coverage Δ
.../navercorp/pinpoint/plugin/mongo/WriteContext.java 12.43% <75.00%> (+12.43%) ⬆️
...avercorp/pinpoint/web/filter/FilterDescriptor.java 83.58% <100.00%> (+0.24%) ⬆️
...pinpoint/rpc/ChannelWriteFailListenableFuture.java 42.85% <0.00%> (-28.58%) ⬇️
...java/com/navercorp/pinpoint/rpc/DefaultFuture.java 74.31% <0.00%> (-1.84%) ⬇️
...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java 51.66% <0.00%> (-1.67%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
...n/server/bo/serializer/trace/v2/SpanEncoderV0.java 82.88% <0.00%> (-0.54%) ⬇️
...n/server/bo/serializer/trace/v2/SpanDecoderV0.java 81.27% <0.00%> (-0.46%) ⬇️
...com/navercorp/pinpoint/common/util/JvmVersion.java 90.74% <0.00%> (+0.54%) ⬆️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.06% <0.00%> (+1.23%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emeroad emeroad linked an issue Oct 31, 2022 that may be closed by this pull request
@emeroad emeroad merged commit 4737dbc into pinpoint-apm:master Oct 31, 2022
@emeroad emeroad deleted the #9350_base64 branch October 31, 2022 09:12
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Base64 with java.util.Base64
1 participant