Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8915] Cleanup junit4 dependency #9365

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Nov 3, 2022

No description provided.

@emeroad emeroad changed the title 8915 Migration from JUnit 4 to JUnit 5 [#8915] Migration from JUnit 4 to JUnit 5 Nov 3, 2022
@emeroad emeroad added this to the 2.5.0 milestone Nov 3, 2022
@emeroad emeroad linked an issue Nov 3, 2022 that may be closed by this pull request
@emeroad emeroad changed the title [#8915] Migration from JUnit 4 to JUnit 5 [#8915] Cleanup junit4 dependency Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #9365 (2b018fd) into master (2c17837) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 2b018fd differs from pull request most recent head c103416. Consider uploading reports for the commit c103416 to get more accurate results

@@             Coverage Diff              @@
##             master    #9365      +/-   ##
============================================
+ Coverage     39.46%   39.49%   +0.02%     
- Complexity    11783    11791       +8     
============================================
  Files          3407     3407              
  Lines         91250    91250              
  Branches      10122    10122              
============================================
+ Hits          36015    36039      +24     
+ Misses        52110    52090      -20     
+ Partials       3125     3121       -4     
Impacted Files Coverage Δ
...n/server/bo/serializer/trace/v2/SpanDecoderV0.java 81.73% <0.00%> (+0.45%) ⬆️
...n/server/bo/serializer/trace/v2/SpanEncoderV0.java 83.42% <0.00%> (+0.53%) ⬆️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.89% <0.00%> (+1.23%) ⬆️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 75.92% <0.00%> (+3.70%) ⬆️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 53.33% <0.00%> (+6.66%) ⬆️
...pc/server/LoggingServerMessageListenerFactory.java 90.47% <0.00%> (+9.52%) ⬆️
...pinpoint/profiler/instrument/AccessorAnalyzer.java 61.29% <0.00%> (+9.67%) ⬆️
...p/pinpoint/rpc/stream/StreamChannelRepository.java 78.94% <0.00%> (+21.05%) ⬆️
...rp/pinpoint/rpc/packet/ControlHandshakePacket.java 68.96% <0.00%> (+24.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emeroad emeroad merged commit 62b576a into pinpoint-apm:master Nov 3, 2022
@emeroad emeroad deleted the #8915_junit5 branch November 3, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration from JUnit 4 to JUnit 5
1 participant