Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9414] Refer classpath for querying available libraries #9416

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

smilu97
Copy link
Member

@smilu97 smilu97 commented Nov 15, 2022

resolves #9414

@smilu97 smilu97 added the test label Nov 15, 2022
@smilu97 smilu97 requested a review from emeroad November 15, 2022 02:27
@smilu97 smilu97 self-assigned this Nov 15, 2022
@smilu97
Copy link
Member Author

smilu97 commented Nov 15, 2022

All changes here are adapted from #7415, but what was in ModuleSupport is excluded because the issue had been already resolved by the other commit

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #9416 (a316f98) into master (a016b52) will decrease coverage by 0.01%.
The diff coverage is 3.77%.

@@             Coverage Diff              @@
##             master    #9416      +/-   ##
============================================
- Coverage     39.53%   39.51%   -0.02%     
- Complexity    11800    11807       +7     
============================================
  Files          3411     3412       +1     
  Lines         91329    91360      +31     
  Branches      10124    10128       +4     
============================================
- Hits          36104    36103       -1     
- Misses        52111    52136      +25     
- Partials       3114     3121       +7     
Impacted Files Coverage Δ
...t/test/plugin/AbstractPinpointPluginTestSuite.java 0.00% <0.00%> (ø)
.../navercorp/pinpoint/test/plugin/LibraryFilter.java 100.00% <100.00%> (ø)
...pinpoint/rpc/ChannelWriteFailListenableFuture.java 42.85% <0.00%> (-28.58%) ⬇️
...p/pinpoint/rpc/client/WriteFailFutureListener.java 56.25% <0.00%> (-25.00%) ⬇️
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...java/com/navercorp/pinpoint/rpc/DefaultFuture.java 74.31% <0.00%> (-1.84%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
...et/PinpointWebSocketTimerTaskDecoratorFactory.java 93.33% <0.00%> (-0.42%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smilu97 smilu97 force-pushed the #9414_test9 branch 3 times, most recently from acbc4ea to 9cb96b6 Compare November 16, 2022 08:39
@smilu97 smilu97 merged commit bb9a5d7 into pinpoint-apm:master Nov 16, 2022
@smilu97 smilu97 deleted the #9414_test9 branch November 16, 2022 10:25
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PinpointPluginTestSuite JDK9+ compatibility
3 participants