Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9504] Move recordUriTemplate() to SpanRecorder #9514

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Dec 15, 2022

No description provided.

@emeroad emeroad linked an issue Dec 15, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #9514 (3ee6dd8) into master (fc13b07) will increase coverage by 0.00%.
The diff coverage is 9.09%.

@@            Coverage Diff            @@
##             master    #9514   +/-   ##
=========================================
  Coverage     38.42%   38.42%           
- Complexity    11779    11782    +3     
=========================================
  Files          3495     3495           
  Lines         93760    93764    +4     
  Branches      10541    10541           
=========================================
+ Hits          36029    36032    +3     
- Misses        54604    54605    +1     
  Partials       3127     3127           
Impacted Files Coverage Δ
...nterceptor/ExposePathWithinMappingInterceptor.java 0.00% <0.00%> (ø)
...eb/interceptor/LookupHandlerMethodInterceptor.java 0.00% <0.00%> (ø)
...lugin/vertx/interceptor/RouteStateInterceptor.java 0.00% <0.00%> (ø)
...orp/pinpoint/profiler/context/AsyncChildTrace.java 1.83% <ø> (+0.03%) ⬆️
...avercorp/pinpoint/profiler/context/AsyncTrace.java 0.00% <ø> (ø)
...ercorp/pinpoint/profiler/context/DefaultTrace.java 61.06% <ø> (+0.91%) ⬆️
...point/profiler/context/DisableAsyncChildTrace.java 33.33% <ø> (+1.90%) ⬆️
...profiler/context/recorder/DisableSpanRecorder.java 8.51% <0.00%> (-0.80%) ⬇️
...ofiler/context/recorder/TraceRootSpanRecorder.java 0.00% <0.00%> (ø)
...profiler/context/recorder/DefaultSpanRecorder.java 25.00% <22.22%> (+1.36%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emeroad emeroad merged commit 69981a4 into pinpoint-apm:master Dec 15, 2022
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to collect URI Template in Trace
1 participant