Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Adding Logger for Kafka Callback #9680

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Feb 6, 2023

No description provided.

Copy link
Member

@minwoo-jung minwoo-jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #9680 (3529785) into master (15a11a4) will decrease coverage by 0.02%.
The diff coverage is 39.13%.

@@             Coverage Diff              @@
##             master    #9680      +/-   ##
============================================
- Coverage     38.95%   38.93%   -0.02%     
+ Complexity    11922    11920       -2     
============================================
  Files          3494     3495       +1     
  Lines         93775    93788      +13     
  Branches      10519    10520       +1     
============================================
- Hits          36530    36517      -13     
- Misses        54074    54095      +21     
- Partials       3171     3176       +5     
Impacted Files Coverage Δ
.../metric/collector/dao/pinot/PinotMetricTagDao.java 0.00% <0.00%> (ø)
...lector/dao/pinot/PinotSystemMetricDataTypeDao.java 0.00% <0.00%> (ø)
...rp/pinpoint/metric/common/util/KafkaCallbacks.java 14.28% <14.28%> (ø)
...ollector/dao/pinot/PinotSystemMetricDoubleDao.java 100.00% <100.00%> (ø)
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (-3.71%) ⬇️
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emeroad emeroad merged commit 8eb1a4e into pinpoint-apm:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants