Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo and Youtube pinning support #6

Closed
overshard opened this issue Mar 13, 2013 · 12 comments
Closed

Vimeo and Youtube pinning support #6

overshard opened this issue Mar 13, 2013 · 12 comments
Assignees
Labels
enhancement A feature request or general improvement

Comments

@overshard
Copy link
Member

The core social video sites for now since they both have easy embeddables. Need to grab a "screenshot" of the video, can be done via the API I think, to put as the pin thumbnail.

@overshard
Copy link
Member Author

Completed in a branch till @kklimonda told me it was terrible and he is building plugin system...

@overshard
Copy link
Member Author

Pending completion of #30

@ghost ghost assigned kklimonda Sep 22, 2013
@rafirosenberg
Copy link

id like to help on this issue .. but i dont want to replicate efforts .. can you update me on where you are holding with this?

@overshard
Copy link
Member Author

It was completed a bit but then we scrapped it till Krzysztof built a plugin system. Both of us got kind of busy and we didn't do either. If you want to re implement it without the plugin system then go ahead and I'll check it out and see about pulling it.

@rafirosenberg
Copy link

great ... il work in it piecemeal .. and you’ll let me know if you like
the style and direction I'm taking .. all the best .. and I think you
got a great thing going so keep it up!

On 01/10/2014 02:22 PM, Isaac Bythewood wrote:

It was completed a bit but then we scrapped it till Krzysztof built a
plugin system. Both of us got kind of busy and we didn't do either. If
you want to re implement it without the plugin system then go ahead
and I'll check it out and see about pulling it.


Reply to this email directly or view it on GitHub
#6 (comment).

@rafirosenberg
Copy link

do you think we would want to play the video on pinry or on youtube (or
both)? Obviously it would be much easier to simply have the image be a
link to the page on youtube/vimeo ... but it may be more user friendly
to play it on the pinry.

do you think we would want to have a different look or shape or
thumbnail sizes for videos? Perhaps they would each need an overlay of a
"video arrow" at the very least

and how about the form.. would we want it to look (be) the same or
different? (I imagine we would want it in the same form, and instead of
saying "image url" .. it might say "image or video url" if we go with one
form for all then we will need to amend the form to distinguish between
a youtube/vimeo urls and then have different functions if it is

@overshard
Copy link
Member Author

How I originally had it implemented is that it pulled a thumbnail from the provider to use as a placeholder on the overall board. Then once you clicked on the thumbnail, like you do any posting, it will go to the lightbox view which then has a Youtube/Vimeo video player and you can just play the video directly from Pinry.

@rafirosenberg
Copy link

great ... im on it... i had aleady staarted this morning ... along those
lines ... ill update you with some progress soon ... since we are using
one light box... I think ill add a js switch to update a youtube prop in
the context .. and maybe well store a youtube id in the core.pins model

@overshard
Copy link
Member Author

Yep, all we really need is the video id from youtube or vimeo... everything else we can pull/just have in the code.

@rafirosenberg
Copy link

could you check out my pull request
#58

and add me as a contributor if you like the work ... there is on small
bug ill work on tonight but let me know if you like where i am going
with it ... thanks

@overshard
Copy link
Member Author

I'm not sure how much interest we have in pinning videos at this point in time, it's basically the same as a "Website URL" pin. I'm closing this.

@lapo-luchini
Copy link
Contributor

OTOH I seldom would like to pin "short mp4", which is such a better* format than "gif" ever was and is finally starting to replace it…
*: as in full 24bit colors occuping 1/10-1/50 than a shiffy 256-colors animation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request or general improvement
Development

No branches or pull requests

4 participants