New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Review #1

Open

1 of 4 tasks

bocon13 opened this issue Nov 9, 2020 · 0 comments

Contributor

bocon13 commented Nov 9, 2020 •

edited by donNewtonAlpha

Loading

Password authentication isn't used in P4RT.

p4rt-client/main.go

Line 15 in 037fedd

// Authentication holds the login/password
Needs a pass from go fmt
Could simplify code by instantiating updates here (applies to all tables/*.go files)

p4rt-client/tables/ipv4table.go

Line 67 in 037fedd

updates=append(updates,&destinationTableUpdate)
Consider storing the fact that we are master/primary somewhere. Then, we can either block or queue P4RT client writes if not primary.

p4rt-client/internal/lib/client.go

Line 33 in 037fedd

log.Println("client is master")

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment