Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the grammar in an assertion failure message #270

Merged
merged 1 commit into from Apr 28, 2020

Conversation

jparise
Copy link
Collaborator

@jparise jparise commented Apr 28, 2020

Also wrap a conditional block in brackets for consistency with the rest
of this file.

Also wrap a conditional block in brackets for consistency with the rest
of this file.
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's!

@garrettmoon garrettmoon merged commit 9f601cc into pinterest:master Apr 28, 2020
adlerj pushed a commit to adlerj/PINCache that referenced this pull request Aug 4, 2020
* commit 'df60b0d9c1903ca4cdb1e928b04ea1203aa28ad2':
  Support Catalyst (pinterest#272)
  Fix the grammar in an assertion failure message (pinterest#270)
  Remove the unused CI directory (pinterest#265)
  Fix up analyze for github CI (pinterest#264)
  Check fileURL outside of the locked scope (pinterest#262)
  Optimization `PINMemoryCache` trim to date (pinterest#252)
  Use correct class name in NSAssert() messages (pinterest#263)
  Remove Danger from the project (pinterest#261)
  Link to master branch workflow from the CI badge
  Test that the "remove object" blocks are called (pinterest#258)
  Fix GitHub Actions CI badge
  Switch to GitHub Actions for CI (pinterest#259)
  Discrepancy between Header Comment and Implementation (pinterest#257)

# Conflicts:
#	Makefile
#	PINCache.xcodeproj/project.pbxproj
#	Tests/PINCacheTests.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants