Merge pull request #32 from pinterest/data_copy

use [data copy] to be extra safe
pinterest · Mar 11, 2024 · 285084c · 285084c
2 parents 689ec2e + 531b653
commit 285084c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/PINFuture/Classes/Categories/PINNSURLSessionDataTaskResult.h b/PINFuture/Classes/Categories/PINNSURLSessionDataTaskResult.h
@@ -14,7 +14,7 @@ NS_ASSUME_NONNULL_BEGIN
 @interface PINNSURLSessionDataTaskResult : NSObject
 
 @property (nonatomic, readonly) NSData * _Nullable data;
-@property (nonatomic, readonly) NSURLResponse * _Nullable response;
+@property (nonatomic, copy, readonly) NSURLResponse * _Nullable response;
 @property (nonatomic, readonly) NSError * _Nullable error;
 
 + (instancetype)resultWithData:(NSData * _Nullable)data

diff --git a/PINFuture/Classes/Categories/PINNSURLSessionDataTaskResult.m b/PINFuture/Classes/Categories/PINNSURLSessionDataTaskResult.m
@@ -11,7 +11,7 @@
 NS_ASSUME_NONNULL_BEGIN
 
 @interface PINNSURLSessionDataTaskResult ()
-@property (nonatomic) NSData * _Nullable data;
+@property (nonatomic, copy) NSData * _Nullable data; //intentionally use copy as the network data might be NSMutableData under the hood
 @property (nonatomic) NSURLResponse * _Nullable response;
 @property (nonatomic) NSError * _Nullable error;
 @end