-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift Package Manager support #32
Conversation
Created Package file
Header file fix
Define public headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@garrettmoon / @jparise Hey! I know it might not be top priority, but we would love to use whole PINRemoteImage in module (framework) through SPM so we are ready to prepare it for SPM for you. Martin started here, will continue with PINCache etc., but it would be nice if you could review this and stay up-to-date with our PRs and keep merging them if you think this is a good idea. Thanks! |
What sort of CI-level check should we have in place to verify that the packaging is (and remains) correct? |
SPM tests
Example project to test Pods integration
Fix typo
Build Example project on CI
Fix typo
Added some code from PINOperation to compile in example project
Hey @jparise thank you for taking a look at this! I added a test target to SPM to run current tests in the package too, that should help verify it's behaving properly. And I added an Example project and build step on CI where we can verify the Cocoapods integration is still working properly after adding SPM and making changes to PINOperation source. Let me please know if you think any other checks or changes are necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Tagging @garrettmoon for a final review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job Martin! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Thank you so much for adding this!
@garrettmoon Thanks for merge! Would you mind bumping version and releasing new one + tag to make this available for PINCache and other parts as SPM already? |
Thank you both so much for the work! I'll get out a new release. |
Published! |
Changes
Package.swift
to support Swift Package Manager without changes to project structure, so hopefully nothing will break for Cocoapods and CarthageAdditional info
build, tests, analyze and
pod lib lint
were all green on my local machine, lets wait for CI and see if everything works