Adding support for automatically skipping cancelation if the amount l… #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eft to be downloaded is less than the average time to first byte.
|
🚫 CI failed with log |
|
🚫 CI failed with log |
jparise
reviewed
May 25, 2017
| break; | ||
|
|
||
| case NSURLSessionTaskStateCompleted: | ||
| NSAssert(self.startTime != 0, @"Expect that task was started before it's completed."); |
| @@ -35,6 +35,8 @@ typedef void (^PINURLSessionDataTaskCompletion)(NSURLSessionTask * _Nonnull task | |||
|
|
|||
| @property (atomic, weak, nullable) id <PINURLSessionManagerDelegate> delegate; | |||
|
|
|||
| - (NSTimeInterval)weightedTimeToFirstByteForHost:(nonnull NSString *)host; | |||
There was a problem hiding this comment.
This would benefit from a brief documentation comment.
| if (metric.requestStartDate == nil || metric.responseStartDate == nil) { | ||
| //Only evaluate requests which completed their first byte. | ||
| valid = NO; | ||
| break; |
There was a problem hiding this comment.
Seems like you could drop the valid flag and just return here.
| NSTimeInterval timeToFirstByte; | ||
| [self lock]; | ||
| timeToFirstByte = [[_timeToFirstByteCache objectForKey:host] doubleValue]; | ||
| if (timeToFirstByte <= 0 + DBL_EPSILON) { |
There was a problem hiding this comment.
You can drop the lock earlier (here).
|
|
||
| - (void)storeTimeToFirstByte:(NSTimeInterval)timeToFirstByte forHost:(NSString *)host | ||
| { | ||
| [self lock]; |
There was a problem hiding this comment.
I wonder if you can get away without locking. NSCache supports concurrent access, and the logic below is sufficiently fuzzy that missing/overwriting a measurement probably won't be super meaningful.
jparise
approved these changes
May 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eft to be downloaded is less than the average time to first byte.
Putting this up in favor of #357